[stable31] feat: support whatsapp signal telegram xmpp token methods#5981
Merged
vitormattos merged 5 commits intostable31from Dec 3, 2025
Merged
[stable31] feat: support whatsapp signal telegram xmpp token methods#5981vitormattos merged 5 commits intostable31from
vitormattos merged 5 commits intostable31from
Conversation
- Keep identify parameter optional for cases like email where user may want to send code to alternative address - Use getIdentifierValue() as fallback when identify is not provided - This ensures token methods (SMS, WhatsApp, etc.) use the registered phone number from the entity Signed-off-by: Vitor Mattos <[email protected]>
- Use factory->get() instead of factory->getGateway() - Use gateway->isComplete() instead of gateway->getConfig()->isComplete() - Compatible with TwoFactorGateway 3.0.0-dev.0 Signed-off-by: Vitor Mattos <[email protected]>
Rename component to reflect its broader use for all token-based authentication methods (SMS, WhatsApp, Signal, Telegram, XMPP) instead of just SMS. Signed-off-by: Vitor Mattos <[email protected]>
Adds needTokenCode() method that checks for any active token-based authentication method (SMS, WhatsApp, Signal, Telegram, XMPP) needing a verification code. This replaces the SMS-only needSmsCode() check and enables proper modal display for all token-based methods. Signed-off-by: Vitor Mattos <[email protected]>
Updates Sign.vue to use the renamed ModalTokenManager component and needTokenCode() method. Changes signWithSMSCode to signWithTokenCode with automatic detection of active token method (SMS, WhatsApp, Signal, Telegram, or XMPP), enabling proper authentication for all token-based signature methods. Signed-off-by: Vitor Mattos <[email protected]>
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #5979